chore(sinks): log reason for non-retryable errors - #25934
Open
petere-datadog wants to merge 3 commits into
Open
Conversation
🎉 All green!🧪 All tests passed 🔗 Commit SHA: aa68c45 | Docs | Datadog PR Page | Give us feedback! |
…ik/OPA-5715/log-reason-for-non-2xx-errors
pront
requested changes
Jul 31, 2026
pront
left a comment
Member
There was a problem hiding this comment.
Logging a response body risks disclosing sensitive data. Destinations can possibly echo data in 4xx responses, and this would create a copy of that data in Vector's error logs, potentially with broader access and longer retention than the original event data.
We already log response bodies at debug level in HttpRetryLogic. Could we do the same for this path, ideally through a shared bounded-body logging helper?
If error-level response-body logging is required for your use case, we could expose an explicit opt-in configuration field so users accept the disclosure risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Log reason for non-retryable errors in http sinks.
Vector configuration
Sample log
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.